Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed states instead of lost states #573

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Closed states instead of lost states #573

merged 1 commit into from
Oct 4, 2019

Conversation

dabcoder
Copy link
Contributor

@dabcoder dabcoder commented Oct 2, 2019

Context: #562

@dabcoder dabcoder marked this pull request as ready for review October 2, 2019 21:34
StephenSorriaux
StephenSorriaux approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@StephenSorriaux StephenSorriaux merged commit 961b2f3 into python-zk:master Oct 4, 2019
@dabcoder dabcoder deleted the davidb/lost-closed-states branch October 4, 2019 10:13
@jeffwidman
Copy link
Member

I ❤️ this! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenSorriaux StephenSorriaux StephenSorriaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabcoder @jeffwidman @StephenSorriaux